RFR: 8320219: Actually resolve issues with goto labels in sspi [v12]

[Julian Waters]

On Fri, 5 Apr 2024 06:31:16 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> I regret not actually addressing the issues with the goto labels in https://github.com/openjdk/jdk/pull/15996, where initialization of locals in sspi were jumped over by gotos to a certain label. I changed the initializations into split declarations and assignments in https://github.com/openjdk/jdk/pull/15996, but this is simply a hack and does not address the real issue of gotos jumping over locals. I've as such fixed the issues with them properly this time, by simply deleting the labels and duplicating the code where they're used. As mentioned, this unfortunately does increase duplicate code, but is the cleanest solution I could come up with for the labels
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Include memory header in sspi.cpp
>  - RAII in sspi.cpp

I've implemented a different approach for one of the methods based on RAII instead, is this perhaps a bit better? If it is I'll convert the rest to use RAII as well

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16682#issuecomment-2041112633