RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries [v2]
Valerie Peng
valeriep at openjdk.org
Tue Apr 16 17:21:11 UTC 2024
> It is reported that some PKCS#11 library/vendor reports major version 3, but doesn't implement the C_GetInterface function and the resulting 'interface' variable value may be NULL and cause unexpected crash later.
>
> This PR would check the 'interface' variable value to be non-NULL.
> Reproducing this would require certain 3rd party PKCS#11 library, and thus the noreg-hard label.
>
> Thanks~
> FYI, I will be on vacation starting 4/17 and will address the review comments upon return.
> Valerie
Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
Removed pre-existing duplicate assignment.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18789/files
- new: https://git.openjdk.org/jdk/pull/18789/files/10b84985..19417b4f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18789&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18789&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/18789.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18789/head:pull/18789
PR: https://git.openjdk.org/jdk/pull/18789
More information about the security-dev
mailing list