RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

[Weijun Wang]

On Wed, 31 Jul 2024 19:26:09 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - update test to include Spi updates
>>  - Update with latest from master
>>    
>>    Merge remote-tracking branch 'origin/master' into kdf-jep-wip
>>    # Please enter a commit message to explain why this merge is necessary,
>>    # especially if it merges an updated upstream into a topic branch.
>>    #
>>    # Lines starting with '#' will be ignored, and an empty message aborts
>>    # the commit.
>>  - add engineGetKDFParameters to the KDFSpi
>>  - code review comment fix for javadoc specification
>>  - change course on null return values from derive methods
>>  - code review comments
>>  - threading refactor + code review comments
>>  - review comments
>>  - review comments
>>  - update code snippet type in KDF
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/d5bcb5a2...dd2ee48f
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 315:
> 
>> 313:     /**
>> 314:      * Defines the input parameters of an Extract operation as defined in <a
>> 315:      * href="http://tools.ietf.org/html/rfc5869">RFC 5869</a>.
> 
> Unless there is a specific section for the case, I don't think you need to provide the link to the RFC in these 3 classes.

Any comment?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1700944227