RFR: 8319332: Security properties files inclusion [v18]

[Martin Balao]

On Wed, 7 Aug 2024 17:58:46 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Throw an IllegalArgumentException exception if Security.setProperty("include", ...) is invoked.
>>   
>>   Co-authored-by: Martin Balao <mbalao at redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>
> src/java.base/share/classes/sun/security/util/PropertyExpander.java line 72:
> 
>> 70:         } catch (ExpandException e) {
>> 71:             // should not happen
>> 72:             throw new RuntimeException("unexpected expansion error: when " +
> 
> Is an `AssertionError` better here?

Yes, we can use an `AssertionError` here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16483#discussion_r1707632235