RFR: 8319332: Security properties files inclusion [v18]

Martin Balao mbalao at openjdk.org
Wed Aug 7 19:23:35 UTC 2024


On Wed, 7 Aug 2024 18:01:19 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Throw an IllegalArgumentException exception if Security.setProperty("include", ...) is invoked.
>>   
>>   Co-authored-by: Martin Balao <mbalao at redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>
> src/java.base/share/conf/security/java.security line 33:
> 
>> 31: #
>> 32: # The special "include" property can be defined one or multiple times in
>> 33: # this file with a filesystem path value. The effect of each definition
> 
> "this file". Is this precise? As described below, It can also appear in included files and the file "java.security.properties" points to.
> 
> Maybe not an issue since no one will be confused. You decide whether to make any update.

I don't see "this file" as strictly necessary given the context so we can remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16483#discussion_r1707731255



More information about the security-dev mailing list