RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

[Kevin Driver]

On Wed, 7 Aug 2024 23:50:16 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - update test to include Spi updates
>>  - Update with latest from master
>>    
>>    Merge remote-tracking branch 'origin/master' into kdf-jep-wip
>>    # Please enter a commit message to explain why this merge is necessary,
>>    # especially if it merges an updated upstream into a topic branch.
>>    #
>>    # Lines starting with '#' will be ignored, and an empty message aborts
>>    # the commit.
>>  - add engineGetKDFParameters to the KDFSpi
>>  - code review comment fix for javadoc specification
>>  - change course on null return values from derive methods
>>  - code review comments
>>  - threading refactor + code review comments
>>  - review comments
>>  - review comments
>>  - update code snippet type in KDF
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/02778490...dd2ee48f
>
> src/java.base/share/classes/javax/crypto/KDF.java line 127:
> 
>> 125: 
>> 126:     /**
>> 127:      * Instantiates a KDF object.
> 
> nit: add comment that this constructor is used when the provider is supplied.

@valeriepeng: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/59a3f02015f7fc3ad81ca29b90d83b1c9bd70fc5. Please resolve this conversation if satisfied.

> src/java.base/share/classes/javax/crypto/KDF.java line 149:
> 
>> 147:     }
>> 148: 
>> 149:     private KDF(Service s, Iterator<Service> t, String algorithm,
> 
> nit: add comment that this constructor is used when no provider is supplied.

@valeriepeng: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/59a3f02015f7fc3ad81ca29b90d83b1c9bd70fc5. Please resolve this conversation if satisfied.

> src/java.base/share/classes/javax/crypto/KDF.java line 527:
> 
>> 525: 
>> 526:     // max number of debug warnings to print from chooseFirstProvider()
>> 527:     private static int warnCount = 10;
> 
> Is this really used?

@valeriepeng: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/59a3f02015f7fc3ad81ca29b90d83b1c9bd70fc5. Please resolve this conversation if satisfied.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1715490535
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1715490767
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1715491335