RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]
Valerie Peng
valeriep at openjdk.org
Tue Aug 13 18:30:57 UTC 2024
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver <kdriver at openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>>
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>
> - update test to include Spi updates
> - Update with latest from master
>
> Merge remote-tracking branch 'origin/master' into kdf-jep-wip
> # Please enter a commit message to explain why this merge is necessary,
> # especially if it merges an updated upstream into a topic branch.
> #
> # Lines starting with '#' will be ignored, and an empty message aborts
> # the commit.
> - add engineGetKDFParameters to the KDFSpi
> - code review comment fix for javadoc specification
> - change course on null return values from derive methods
> - code review comments
> - threading refactor + code review comments
> - review comments
> - review comments
> - update code snippet type in KDF
> - ... and 6 more: https://git.openjdk.org/jdk/compare/4f108e38...dd2ee48f
src/java.base/share/classes/javax/crypto/KDF.java line 469:
> 467: * @throws InvalidAlgorithmParameterException
> 468: * if the information contained within the {@code kdfParameterSpec} is
> 469: * invalid, if {@code alg} is invalid, or if their combination
Again, what is the definition of `alg` being invalid? Would it be clearer to just refer to `KDFSpi.engineDeriveKey()` and not duplicating the words here?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1715743461
More information about the security-dev
mailing list