RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Valerie Peng valeriep at openjdk.org
Tue Aug 13 23:04:52 UTC 2024


On Mon, 5 Aug 2024 18:00:08 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Not sure. Maybe your sentence is OK.
>
> I agree that this might lead to some question as to whether a `derive` method can be called concurrently. I think we should just remove this sentence. I think one should assume a method can be called more than once without saying that. If there was some reason this method could not be called more than once, then it should throw `IllegalStateException` or some such similar exception.
> 
> If you still feel like you want to emphasize the method can be called more than once, I would add it to the example in the class description.

I don't see the need to emphasize the method can be called more than once... Is there any other JDK class which does this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1716069044



More information about the security-dev mailing list