RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Valerie Peng valeriep at openjdk.org
Wed Aug 14 00:04:53 UTC 2024


On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressed several review comments, namely: - renaming the getParameters method - renaming the AlgorithmParameterSpec object - address some javadoc exception messages - add some information to KDF class private constructor javadocs - other general cleanup

src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 262:

> 260:                 throw new NullPointerException(
> 261:                     "salt must not be null");
> 262:             }

Why not use `Objects.requireNonNull(T, String)`? Same goes to all other `addXXX()` methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1716126563



More information about the security-dev mailing list