RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Valerie Peng valeriep at openjdk.org
Wed Aug 14 02:53:57 UTC 2024


On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressed several review comments, namely: - renaming the getParameters method - renaming the AlgorithmParameterSpec object - address some javadoc exception messages - add some information to KDF class private constructor javadocs - other general cleanup

src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 86:

> 84:      *
> 85:      * @throws InvalidAlgorithmParameterException
> 86:      *     if the information contained within the {@code KDFParameterSpec} is

typo: `KDFParaneterSpec` should be `derivationParameterSpec`.
BTW, I assume the javadoc is copied from `KDFSpi` class. I'd suggest to shorten it and match it to the actual implementation instead of the general description as in `KDFSpi`.
For the last sentence, do you have an example of how the `derivationParameterSpec` typed `HKDFParameterSpec` can specify a type of output that is not a key?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1716244326



More information about the security-dev mailing list