RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

[Kevin Driver]

On Tue, 13 Aug 2024 18:24:58 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - update test to include Spi updates
>>  - Update with latest from master
>>    
>>    Merge remote-tracking branch 'origin/master' into kdf-jep-wip
>>    # Please enter a commit message to explain why this merge is necessary,
>>    # especially if it merges an updated upstream into a topic branch.
>>    #
>>    # Lines starting with '#' will be ignored, and an empty message aborts
>>    # the commit.
>>  - add engineGetKDFParameters to the KDFSpi
>>  - code review comment fix for javadoc specification
>>  - change course on null return values from derive methods
>>  - code review comments
>>  - threading refactor + code review comments
>>  - review comments
>>  - review comments
>>  - update code snippet type in KDF
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/25421783...dd2ee48f
>
> src/java.base/share/classes/javax/crypto/KDF.java line 479:
> 
>> 477:         throws InvalidAlgorithmParameterException {
>> 478: 
>> 479:             if (alg == null || alg.isEmpty()) {
> 
> Well, should NPE be thrown for empty string? Is there any precedent? The above javadoc for NPE does not state so?

I agree. I'll add `NoSuchAlgorithmException` to the method signature.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720204539