RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Valerie Peng valeriep at openjdk.org
Fri Aug 16 22:12:00 UTC 2024


On Fri, 16 Aug 2024 21:07:55 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 262:
>> 
>>> 260:                 throw new NullPointerException(
>>> 261:                     "salt must not be null");
>>> 262:             }
>> 
>> Why not use `Objects.requireNonNull(T, String)`? Same goes to all other `addXXX()` methods.
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. Please indicate if this is resolved.

Yes

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720396249



More information about the security-dev mailing list