RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms

Valerie Peng valeriep at openjdk.org
Mon Aug 19 21:42:51 UTC 2024


On Tue, 6 Aug 2024 22:39:59 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 1297:
>> 
>>> 1295:                 new HashMap<Descriptor,Integer>();
>>> 1296: 
>>> 1297:         for (long longMech : supportedMechanisms) {
>> 
>> Is the code under `if (!config.isEnabled(longMech)) {` still needed? Looks to me that we will be iterating over enabled mechanisms now.
>
> Just for the record, I want to note that we will not longer be showing information about supported but disabled mechanisms here.

Right, I agree that it's better to show info about supported but disabled mechanisms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20207#discussion_r1722377585



More information about the security-dev mailing list