RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

Kevin Driver kdriver at openjdk.org
Mon Aug 26 18:23:14 UTC 2024


On Mon, 26 Aug 2024 17:48:39 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comments and test renaming
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 54:
> 
>> 52:  * {@code KDFParameters} may throw an {@code InvalidAlgorithmParameterException}
>> 53:  * upon receiving a {@code null} value. Furthermore, implementations
>> 54:  * may supply default values for {@code KDFParameters}, mutating the
> 
> The `mutating` word is suspicious. The object is very likely to be immutable. Just say a different object should be returned in the next sentence.

This depends on the implementation. It may be just as inaccurate to say "a different object".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1731634588



More information about the security-dev mailing list