RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

Sean Mullan mullan at openjdk.org
Wed Aug 28 11:45:37 UTC 2024


On Tue, 13 Aug 2024 15:19:30 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDF.java line 458:
>> 
>>> 456:      * @param alg
>>> 457:      *     the algorithm of the resultant {@code SecretKey} object
>>> 458:      * @param kdfParameterSpec
>> 
>> I think this parameter should be renamed to `derivationParameterSpec` (or something similar) to avoid confusion with the `kdfParameterSpec` variable passed to `getInstance`.
>
> @seanjmullan: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/59a3f02015f7fc3ad81ca29b90d83b1c9bd70fc5. Please resolve this conversation if satisfied.

resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1734528256


More information about the security-dev mailing list