RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

Weijun Wang weijun at openjdk.org
Wed Aug 28 18:44:31 UTC 2024


On Tue, 27 Aug 2024 10:39:12 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comments and test renaming
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 142:
> 
>> 140:          *     if {@code length} is not greater than 0
>> 141:          */
>> 142:         public ExtractThenExpand thenExpand(byte[] info, int length) {
> 
> If it is a fairly common use case to not have an `info` parameter, then I think we should add a method that does not take this parameter, i.e. `thenExpand(int length)`.

Every time HKDF-Expand is used either in TLS 1.3 or HPKE, there is always a non-empty info.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1735138056


More information about the security-dev mailing list