RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms [v2]

Weijun Wang weijun at openjdk.org
Thu Aug 29 17:38:19 UTC 2024


On Wed, 21 Aug 2024 00:09:25 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Can someone help review this fix? Changed the required-mechanism check by checking if the particular mechanism is inside the list of enabled supported mechanisms. This should be more reliable than calling C_GetMechanismInfo(..) on the required mechanism given vendors may return various sorts of error codes.
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments and reverted back to iterating through all available
>   mechanisms.

Change looks fine.

-------------

Marked as reviewed by weijun (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20207#pullrequestreview-2269632024


More information about the security-dev mailing list