RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

Kevin Driver kdriver at openjdk.org
Thu Aug 29 17:53:31 UTC 2024


On Mon, 26 Aug 2024 17:37:50 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comments and test renaming
>
> src/java.base/share/classes/java/security/KDFParameters.java line 43:
> 
>> 41:  * <p>
>> 42:  * The {@code KDFParameters} used for initialization can be retrieved via
>> 43:  * {@link javax.crypto.KDF#getParameters()}.
> 
> Since you add this line here right after the "initialized with" line, there should be some words about the difference between the user-provided params and actual params.

I think the reference to `KDF#getParameters()` is meant to refer the reader to the information there, rather than repeating it again here. Thoughts?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1736824784


More information about the security-dev mailing list