RFR: 8298420: PEM API: Implementation (Preview) [v4]

[Sean Mullan]

On Thu, 1 Aug 2024 04:13:24 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   pemrecord whitespace

src/java.base/share/classes/java/security/PEMEncoder.java line 183:

> 181:                 }
> 182:             }
> 183:             case Certificate c -> {

Shouldn't this be `X509Certificate` and `X509CRL` for line 191 since those are the permitted `DerEncodable` subtypes? I'm assuming it would be an error (compiler?) to try to pass in other subtypes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1737034149