RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v16]

Kevin Driver kdriver at openjdk.org
Thu Aug 29 19:44:31 UTC 2024


On Thu, 29 Aug 2024 16:38:52 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - consistency with wording for addIKM and addSalt
>>  - another round of code review comments
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 60:
> 
>> 58:  * AlgorithmParameterSpec kdfParameterSpec =
>> 59:  *             HKDFParameterSpec.ofExtract()
>> 60:  *                              .addIKM(label)
> 
> .addIKM(label) need to be removed here.

No, this is correct. The user may chain multiple calls to addIKM to add multiple values.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1737055600


More information about the security-dev mailing list