RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Kevin Driver kdriver at openjdk.org
Thu Aug 29 20:06:07 UTC 2024


On Thu, 29 Aug 2024 18:50:26 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Well, if a non-extractrable hardware key is passed to us, it'd lead to NPE with the new check. Instead of calling getEncoded() on it and access  length directly, maybe relying on `CipherCore.getKeyBytes(prk)` which will throw InvalidKeyException?
>
> Given that this comment is marked resolved(?), I am going to copy the above comment to the new version and start a new conversation so it's more visible.

Addressed in https://github.com/openjdk/jdk/pull/20301/commits/deadc28d6d81f5ecc056b38762f6cda49fd0cfe5. Please confirm.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1737089079


More information about the security-dev mailing list