RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v16]

Kevin Driver kdriver at openjdk.org
Thu Aug 29 20:06:08 UTC 2024


On Wed, 28 Aug 2024 23:51:38 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - consistency with wording for addIKM and addSalt
>>  - another round of code review comments
>
> test/jdk/javax/crypto/KDF/KDFDelayedProviderSyncTest.java line 66:
> 
>> 64:     public void testDerive()
>> 65:         throws InvalidAlgorithmParameterException, NoSuchAlgorithmException {
>> 66:         SecretKey result = kdfUnderTest.deriveKey("AES", kdfParameterSpec);
> 
> Here the key algorithm is "AES" with output length 42 bytes. However, AES only has 128, 192, and 256-bits key sizes though. Based on the javadoc, this combination is not valid and should throw IAPE? Maybe use some other algorithm as the key algorithm?

Addressed in https://github.com/openjdk/jdk/pull/20301/commits/deadc28d6d81f5ecc056b38762f6cda49fd0cfe5. Please confirm.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1737093190


More information about the security-dev mailing list