RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v17]
Kevin Driver
kdriver at openjdk.org
Thu Aug 29 20:06:08 UTC 2024
On Thu, 29 Aug 2024 00:33:00 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> another round of review comments
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 287:
>
>> 285: *
>> 286: * @implNote HKDF implementations will enforce that the length is less than
>> 287: * 255 * HMAC length.
>
> It will also check the size of `prk`.
Addressed in https://github.com/openjdk/jdk/pull/20301/commits/deadc28d6d81f5ecc056b38762f6cda49fd0cfe5. Please confirm.
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 365:
>
>> 363: * modification
>> 364: * @param length
>> 365: * the length of the output keying material (must be > 0 and < 255 *
>
> Make the same change on the upper limit of `length` as line 286.
Addressed in https://github.com/openjdk/jdk/pull/20301/commits/deadc28d6d81f5ecc056b38762f6cda49fd0cfe5. Please confirm.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1737093449
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1737094093
More information about the security-dev
mailing list