RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

Kevin Driver kdriver at openjdk.org
Fri Aug 30 22:38:40 UTC 2024


On Fri, 16 Aug 2024 21:06:51 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDF.java line 441:
>> 
>>> 439:     }
>>> 440: 
>>> 441:     private static KDF handleException(NoSuchAlgorithmException e)
>> 
>> My comment originates more with the callers of this method. While I appreciate that you are trying to throw correct exception for the situation, you may have noticed that if the developer calls a `getInstance()` which only throws `NSAE` (line 216 for example), you could be in a situation where you unwrap the causing `IAPE` from the wrapping `NSAE`, to then rewrap it in a `NSAE` on line 219.   I may be just better to let the provider throw what they want and not try to modify it.
>
> Nit. May address later.

Likely addressed partially by https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. The rest of the behavior is modeled after CertStore and behaves similarly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1739485477


More information about the security-dev mailing list