RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

Sean Mullan mullan at openjdk.org
Mon Dec 2 15:32:40 UTC 2024


On Thu, 28 Nov 2024 16:20:56 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Sean Mullan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removal of unused fields from AccessControlContext - no longer needed now that VM cleanup is done.
>
> src/java.base/share/classes/java/security/Provider.java line 1:
> 
>> 1: /*
> 
> Hi @seanjmullan,
> 
> This is very minor/nit, but, while adapting #15539 for the upcoming changes in this PR (and the whole work in [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411 "Implement JEP 486: Permanently Disable the Security Manager")), I found the following comments, which we will also want to remove.
> 
> https://github.com/openjdk/jdk/blob/8abeb41b740534e832135a9e29f53460e4c509f2/src/java.base/share/classes/java/security/Provider.java#L348-L352
> https://github.com/openjdk/jdk/blob/8abeb41b740534e832135a9e29f53460e4c509f2/src/java.base/share/classes/java/security/Provider.java#L779-L780
> 
> EDIT: If you prefer not to touch this here (to avoid re-build and re-test delays), I can remove these comments as part of [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix bugs and inconsistencies in the Provider services map") (which will include some previous fixes to make #15539 smaller).

Good catch. Also noticed a couple of other comments with "permission" and removed that text. Fixed in https://github.com/openjdk/jdk/pull/22418/commits/283fb2c12cbfb3a34a22fa3760d0879767ceefe0

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22418#discussion_r1866058714


More information about the security-dev mailing list