RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

Sean Mullan mullan at openjdk.org
Mon Dec 2 18:27:39 UTC 2024


On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Now that JEP 486 has been integrated, `java.security` and `sun.security` implementation dependencies on `System.getSecurityManager` and `AccessController.doPrivileged` can be removed. 
>> 
>> This should cover most of the remaining cleanup in the security libraries area. A couple of the `sun.security.action` classes can't be removed yet, as well as a few constants in `sun.security.util.SecurityConstants` and internal `ProtectionDomain` methods until dependencies are removed in other areas. Some additional test cleanup can also be done later.
>
> Sean Mullan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove PutAllAction and GetBooleanAction classes as there are no more dependencies.
>   Move GetPropertyAction.privilegedGetTimeoutProp and privilegedGetBooleanProp
>   methods to sun.security.util.SecurityProperties and rename them.

Just pushed another set of changes:

- `PutAllAction` and `GetBooleanAction` from the `sun.security.action` package have been removed as there are no more dependencies. The last remaining action class is `GetPropertyAction` but there are still many dependencies left.
- Moved the `privilegedGetTimeoutProp` and `privilegedGetBooleanProp` methods from `sun.security.action.GetPropertyAction` to `sun.security.util.SecurityProperties` and renamed them.

This should be the last changes for this issue, unless there are more comments, or testing reveals any issues. So, please re-review this update. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22418#issuecomment-2512341122


More information about the security-dev mailing list