RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications [v2]

[Sean Mullan]

On Tue, 3 Dec 2024 22:26:17 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> A few additional changes should be made to the API specs for these classes .  These changes are documenting behavior of other APIs that has already been approved as part of JEP 486, so I don't think a CSR is necessary, but opinions on that are welcome.
>> 
>> The `DomainCombiner` and `SubjectDomainCombiner` classes contain wording about "inherited" and"privileged" `ProtectionDomain`s which is no longer  implemented, and so has been removed. The `PrivilegedAction` classes also contained wording about "privileged" computations which is no longer accurate. I also added an API note to these classes, similar to the ones in the `Permission` subclasses. Finally, I removed a couple of instances of "privileged work" from the `Subject` class which no longer applies.
>
> Sean Mullan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove api notes.

After a side discussion with a colleague, I removed the API notes in `PrivilegedAction` and `PrivilegedExceptionAction` as the wording was hard to get right. Anyone using these APIs with the `AccessController` or `Subject` APIs will find those corresponding methods that take these actions as parameters to have very clear definitions of the change in behavior, so the note is not necessary.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22500#issuecomment-2515681679