RFR: 8343622: AesDkCrypto.stringToKey should not return null [v5]
Valerie Peng
valeriep at openjdk.org
Thu Dec 5 04:23:45 UTC 2024
On Thu, 5 Dec 2024 04:10:31 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> When an exception happens inside these stringToKey() methods, it returns a null. This would lead to unexpected NPE some time in the future.
>
> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into 8343622
> - update copyright years
> - add cause to exception
> - let it throw NSAE
> - 8343622: AesDkCrypto.stringToKey should not return null
Looks good~
-------------
Marked as reviewed by valeriep (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21908#pullrequestreview-2480388075
More information about the security-dev
mailing list