RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v2]

SendaoYan syan at openjdk.org
Mon Dec 9 04:16:23 UTC 2024


> Hi all,
> File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug configure. This PR undefine `dprintf` before define dprintf macro, to avoid deplication macro definition to linux header `/usr/include/bits/stdio2.h`, risk is low.
> 
> Additional testing:
> 
> - [x] build with fastdebug and release configure by gcc14 on linux-x64
> - [ ] jtreg tests(include tier1/2/3) on linux-x64 with release build
> - [ ] jtreg tests(include tier1/2/3) on linux-x64 with fastdebug build
> - [ ] jtreg tests(include tier1/2/3) on linux-aarch64 with release build
> - [ ] jtreg tests(include tier1/2/3) on linux-aarch64 with fastdebug build

SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into jbs8345757
 - 8345757: [ASAN] clang17 report dprintf macro redefined

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22630/files
  - new: https://git.openjdk.org/jdk/pull/22630/files/c6c8c66f..2a1671ac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22630&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22630&range=00-01

  Stats: 99 lines in 10 files changed: 20 ins; 70 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/22630.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22630/head:pull/22630

PR: https://git.openjdk.org/jdk/pull/22630


More information about the security-dev mailing list