RFR: 8346436: Compilation with clang fails

[Phil Race]

On Tue, 17 Dec 2024 14:57:42 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> clang-18.1.8-1.fc40.x86_64
> Fedora 40 x86_64
> fbd76ca8edd756ff2ebbc9f6477cc1a827df67b0
> 
> 
> src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
>   695 | write ( AWT_WRITEPIPE, &wakeUp_char, 1 );
>       | ^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c:375:9: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
>   375 | write(splash->controlpipe[1], &code, 1);
>       | ^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c:713:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
>   713 | pipe(splash->controlpipe);
>       | ^~~~ ~~~~~~~~~~~~~~~~~~~
> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h:45:9: error: 'dprintf' macro redefined [-Werror,-Wmacro-redefined]
>    45 | #define dprintf(s)
>       | ^
> /usr/include/bits/stdio2.h:121:12: note: previous definition is here
>   121 | # define dprintf(fd, ...) \
>       | ^
> src/java.smartcardio/share/native/libj2pcsc/pcsc.c:48:9: error: 'dprintf' macro redefined [-Werror,-Wmacro-redefined]
>    48 | #define dprintf(s)
>       | ^
> /usr/include/bits/stdio2.h:121:12: note: previous definition is here
>   121 | # define dprintf(fd, ...) \
>       | ^

This fix covers multiple areas. It needs at least 2 reviewers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22794#issuecomment-2557553099