RFR: 8345840: Add missing TLS handshake messages to SSLHandshake.java

Jamil Nimeh jnimeh at openjdk.org
Mon Dec 23 18:39:35 UTC 2024


On Tue, 10 Dec 2024 06:25:51 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

> SunJSSE has many of the IANA TLS handshake message types defined, but some are reserved and could be added for debugging output.
> 
> https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
> 
> Testing coverage:  JDK compilation only.

Other than the one cut-paste error on line 376, it looks good to me.

src/java.base/share/classes/sun/security/ssl/SSLHandshake.java line 376:

> 374: 
> 375:     // RFC 8870 - Encrypted Key Transport for DTLS/Secure RTP
> 376:     EKT_KEY                     ((byte)0x19, "ekt_key"),

EKT_KEY should have a value of 0x1A (26).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22657#pullrequestreview-2521012506
PR Review Comment: https://git.openjdk.org/jdk/pull/22657#discussion_r1896026141


More information about the security-dev mailing list