RFR: 8321274: Rename ZipEntry.extraAttributes to ZipEntry.externalAttributes [v2]

[Eirik Bjørsnøs]

On Fri, 2 Feb 2024 19:55:51 GMT, Lance Andersen <lancea at openjdk.org> wrote:

> I think the change is OK, any reason to not make it `externalFileAttributes`?

None other than length / verbosity.  But since this refers to the _attributes of the external file_, dropping any name element also loses some semantics, introducing a potential for confusion. Perhaps verbosity is the sensible choice here.

If you agree to the above, I can update the PR to rename to the following names instead:

- `ZipFile.externalFileAttributes`
- `JavaUtilZipFileAccess.java.[set|get]ExternalFileAttributes`
- `JarSigner.externalFileAttributesDetected`
- `jarsigner/Main.externalFileAttributesDetected`
- `external.file.attributes.detected` in `Resources.java`

WDYT?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16952#issuecomment-1924638322