RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG [v4]

Oli Gillespie ogillespie at openjdk.org
Wed Feb 7 09:49:10 UTC 2024


> A typical call to `new SecureRandom()` is slowed down by looking for a constructor in NativePRNG which takes `java.security.SecureRandomParameters`. NativePRNG does not have such a constructor, so the search fails [here](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/security/Provider.java#L1951-L1957), incurring all the cost of the lookup and creating a subsequent exception.
> 
> Creating a dummy constructor which takes and ignores this parameter will speed up `new SecureRandom()` calls significantly. 
> 
> The benchmark from https://github.com/openjdk/jdk/pull/17559 shows around 80% reduction in time taken to create a new SecureRandom with NativePRNG (default on my machine).
> 
> 
> Before
> SecureRandomBench.newSecureRandom  avgt  2930 ± 50 ns/op
> 
> After
> SecureRandomBench.newSecureRandom  avgt  510 ± 16 ns/op

Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision:

  Remove super() calls

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17560/files
  - new: https://git.openjdk.org/jdk/pull/17560/files/44958eff..e51350b7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17560&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17560&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17560.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17560/head:pull/17560

PR: https://git.openjdk.org/jdk/pull/17560



More information about the security-dev mailing list