RFR: JDK-8311644 Server should not send bad_certificate alert when the client does not send any certificates
John Jiang
jjiang at openjdk.org
Tue Feb 13 12:12:05 UTC 2024
On Tue, 6 Feb 2024 01:23:00 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
> Hi,
>
> I need a code review of what is really a text change. This changes the alert type returned during some TLS CertificateMessage failures to what is recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An additional change was to add the alert description to the thrown exception. This makes it easier for the user to know the alert type and makes testing easier. Two of the three changes are tested as the final one is too hard to test. A few tests needed change as they did string comparing on exception messages.
>
> Tony
src/java.base/share/classes/sun/security/ssl/Alert.java line 126:
> 124:
> 125: if (cause instanceof IOException) {
> 126: return new SSLException("("+ description + ") " + reason, cause);
It should need a space between `"("` and `+`.
Could you please define a new local variable for this expression?
This variable can be reused by the below exceptions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17717#discussion_r1487739265
More information about the security-dev
mailing list