RFR: JDK-8311644 Server should not send bad_certificate alert when the client does not send any certificates

[John Jiang]

On Tue, 6 Feb 2024 01:23:00 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> Hi,
> 
> I need a code review of what is really a text change.  This changes the alert type returned during some TLS CertificateMessage failures to what is recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446).  An additional change was to add the alert description to the thrown exception.  This makes it easier for the user to know the alert type and makes testing easier.  Two of the three changes are tested as the final one is too hard to test.  A few tests needed change as they did string comparing on exception messages.
> 
> Tony

test/jdk/javax/net/ssl/templates/TLSBase.java line 67:

> 65:     TLSBase() {
> 66:         String keyFilename =
> 67:             System.getProperty("test.src", "./") + "/" + pathToStores +

It looks you prefer to 4-spaces indent for these cases.
But line 67 and  71 should have the same indent.
This same to line 68 and 71.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17717#discussion_r1487751390