RFR: 8325162: Remove duplicate GCMParameters class

Daniel Jeliński djelinski at openjdk.org
Tue Feb 13 14:33:03 UTC 2024


On Mon, 12 Feb 2024 08:34:24 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Currently we have 2 GCMParameters classes in java.base, one in sun.security.util package, the other in com.sun.crypto.provider.
> 
> This PR merges the changes from the sun.security.util copy into com.sun.crypto.provider, and removes the sun.security.util class.
> 
> As far as I could tell, the sun.security.util class was added to avoid exporting com.sun.crypto.provider to jdk.crypto.cryptoki. The export was introduced later in [JDK-8259319](https://bugs.openjdk.org/browse/JDK-8259319), so there's no reason to keep both copies.
> 
> No new tests. Tier1-3 tests continue to pass.

mostly because the com.sun.crypto.provider was older (copyright 2013 vs 2019 on the other one). but I don't have a strong preference. I can keep the other one if you think it makes sense.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17802#issuecomment-1941642540



More information about the security-dev mailing list