RFR: 8325162: Remove duplicate GCMParameters class
Daniel Jeliński
djelinski at openjdk.org
Tue Feb 13 15:49:03 UTC 2024
On Mon, 12 Feb 2024 08:34:24 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Currently we have 2 GCMParameters classes in java.base, one in sun.security.util package, the other in com.sun.crypto.provider.
>
> This PR merges the changes from the sun.security.util copy into com.sun.crypto.provider, and removes the sun.security.util class.
>
> As far as I could tell, the sun.security.util class was added to avoid exporting com.sun.crypto.provider to jdk.crypto.cryptoki. The export was introduced later in [JDK-8259319](https://bugs.openjdk.org/browse/JDK-8259319), so there's no reason to keep both copies.
>
> No new tests. Tier1-3 tests continue to pass.
They are both used. The old one is used by [SunJCE](https://github.com/openjdk/jdk/blob/13d9e8ff38536287b82c54bb63bd2d20f65615dc/src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java#L552), and the new one is used by PKCS11.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17802#issuecomment-1941831340
More information about the security-dev
mailing list