RFR: 8325162: Remove duplicate GCMParameters class [v2]

Daniel Jeliński djelinski at openjdk.org
Wed Feb 14 07:14:53 UTC 2024


On Wed, 14 Feb 2024 02:50:21 GMT, John Jiang <jjiang at openjdk.org> wrote:

> `com.sun.crypto.provider.GCMParameters` implies that class is a part of `SunJCE` provider, however `sun.security.util.GCMParameters` looks not.

True. Also, the only other Parameters class in `sun.security.util` is `ECParameters`, which was moved to that package in 3d60beae0d773ba2f626a213e952fbf0e9f1db2b to avoid exporting `sun.security.ec` package to `jdk.crypto.cryptoki` module.

SunPKCS11 is already importing [com.sun.crypto.provider.ChaCha20Poly1305Parameters](https://github.com/openjdk/jdk/blob/ea4193222f36b0663a8bcbf45db86def9e645945/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java#L707), and in #17816 I'm proposing to import another parameters class from `com.sun.crypto.provider`.

I guess it would make sense to decide here if we want to move parameters shared between SunPKCS11 and some other provider to `sun.security.util`, or if we want to keep them in their original location.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17802#issuecomment-1943198182



More information about the security-dev mailing list