RFR: 8319651: Several network tests ignore vm flags when start java process

Andrey Turbanov aturbanov at openjdk.org
Wed Feb 14 09:08:54 UTC 2024


On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

> Currently these tests ignore vm flags, In most cases I've updated them to use `ProcessTools.createTestJavaProcessBuilder` this usually required some cleanup also.
> 
> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and `test/jdk/java/net/URLConnection/6212146/TestDriver.java` have been set to use `@require vm.flagless` because they both use `sh` commands.
> 
> I've ran these changes against tiers 1-3 and everything seems stable

test/jdk/java/net/ServerSocket/AcceptInheritHandle.java line 105:

> 103: 
> 104:         System.out.println("Executing: "+ commands);
> 105:         ProcessBuilder pb =  ProcessTools.createTestJavaProcessBuilder(commands);

Suggestion:

        ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(commands);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17787#discussion_r1489135734



More information about the security-dev mailing list