RFR: 8319651: Several network tests ignore vm flags when start java process

Jaikiran Pai jpai at openjdk.org
Thu Feb 15 12:08:02 UTC 2024


On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

> Currently these tests ignore vm flags, In most cases I've updated them to use `ProcessTools.createTestJavaProcessBuilder` this usually required some cleanup also.
> 
> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and `test/jdk/java/net/URLConnection/6212146/TestDriver.java` have been set to use `@require vm.flagless` because they both use `sh` commands.
> 
> I've ran these changes against tiers 1-3 and everything seems stable

These changes look good to me.

The `TLSWontNegotiateDisabledCipherAlgos.java` would need a copyright year update.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17787#pullrequestreview-1882605013



More information about the security-dev mailing list