RFR: JDK-8311644 Server should not send bad_certificate alert when the client does not send any certificates [v2]

John Jiang jjiang at openjdk.org
Fri Feb 23 02:34:54 UTC 2024


On Thu, 22 Feb 2024 22:41:10 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi,
>> 
>> I need a code review of what is really a text change.  This changes the alert type returned during some TLS CertificateMessage failures to what is recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446).  An additional change was to add the alert description to the thrown exception.  This makes it easier for the user to know the alert type and makes testing easier.  Two of the three changes are tested as the final one is too hard to test.  A few tests needed change as they did string comparing on exception messages.
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Thanks for the updates!

-------------

Marked as reviewed by jjiang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17717#pullrequestreview-1897297466



More information about the security-dev mailing list