RFR: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179 [v2]

Weijun Wang weijun at openjdk.org
Tue Feb 27 21:09:05 UTC 2024


On Tue, 27 Feb 2024 19:17:37 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use calloc
>
> src/java.security.jgss/share/native/libj2gss/GSSLibStub.c line 199:
> 
>> 197:   }
>> 198: 
>> 199:   cb = calloc(1, sizeof(struct gss_channel_bindings_struct));
> 
> With this update, memset calls at line 220 are unnecessary.

Correct! I can remove 2 other lines as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18015#discussion_r1504989534



More information about the security-dev mailing list