RFR: 8326687: Inconsistent use of "ZIP", "Zip" and "zip" in java.util.zip/jar zipfs javadoc [v2]
Guoxiong Li
gli at openjdk.org
Wed Feb 28 14:16:44 UTC 2024
On Tue, 27 Feb 2024 16:15:06 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> This PR updates the javadoc and comments within java.util.zip/jar and zipfs module summary so that it is consistent with the use of "ZIP".
>>
>> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java has been updated to point to the higher level location of the PKWARE APPNOTE.TXT has PKWare recently changed the direct path the the latest version of the spec.
>>
>> It is also worth noting that error messages were not updated as part of the PR and will be updated separately to keep the javadoc changes separate
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>
> Address initial feedback for JDK-8326687
I search the package `java.util.zip` and find several `zip64` in the file [ZipConstants64.java](https://github.com/openjdk/jdk/blob/baa67f1130947c7204fc12018d25bfb48528784c/src/java.base/share/classes/java/util/zip/ZipConstants64.java#L51). It seems you didn't fix all the files in the package `java.util.zip/jar`. Is it your intent? Or you miss some files?
-------------
PR Review: https://git.openjdk.org/jdk/pull/18011#pullrequestreview-1906378373
More information about the security-dev
mailing list