RFR: 8265372: Simplify PKCS9Attribute [v2]

[Valerie Peng]

On Thu, 4 Jan 2024 20:44:01 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor fixes to make the code more readable, inlined init(), removed PKCS9Attributes.getAttributes()
>
> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 218:
> 
>> 216:     private static void add(ObjectIdentifier oid, boolean singleValued,
>> 217:                             Class<?> valueClass, byte... valueTags) {
>> 218:         AttributeInfo info = new AttributeInfo(valueTags,valueClass,singleValued);
> 
> Nit: add a space after ','.

nit: match the ordering of arguments here w/ the one used in record?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17132#discussion_r1446811223