RFR: 8265372: Simplify PKCS9Attribute [v2]

[Valerie Peng]

On Thu, 4 Jan 2024 21:04:12 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor fixes to make the code more readable, inlined init(), removed PKCS9Attributes.getAttributes()
>
> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 321:
> 
>> 319: 
>> 320:         this.oid = oid;
>> 321:         info = oidMap.get(oid);
> 
> What if `info` is `null` (there is no entry for the specified OID)? The prior code set the value class to `byte[]` in that case. I think we want to preserve that behavior.

So, it seems that no test is triggering a NPE? Consider adding a test for covering this scenario?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17132#discussion_r1446827158