RFR: 8317431: Implement simpler Comparator when building certification paths [v2]

Sean Mullan mullan at openjdk.org
Thu Jan 11 14:09:42 UTC 2024


On Wed, 10 Jan 2024 17:00:42 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Sean Mullan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add more comments. Remove unnecessary import.
>
> src/java.base/share/classes/sun/security/provider/certpath/ForwardBuilder.java line 523:
> 
>> 521:                 }
>> 522:                 if (tAo1 != null) {
>> 523:                     if (tAo2 != null) {
> 
> Maybe it's unfamiliarity with this code, but I think we could use some comments here, especially since a similar condition is tested on line 534 (except tAo1 would be null in that case?).

Added more comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17248#discussion_r1448917072



More information about the security-dev mailing list