RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v6]

Matthias Baesken mbaesken at openjdk.org
Thu Jan 11 14:18:30 UTC 2024


On Thu, 4 Jan 2024 15:21:39 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> In this PR, I included logic to skip tests on Oracle Linux prior to version 8.  The NSS binaries we are using for testing use a newer version of GLIBC than is included with OL 7.9.
>
> Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - added additional class to @build tag
>  - Merge branch 'master' into pkcs11-ol79
>  - Merge branch 'master' into pkcs11-ol79
>  - added isOracleLinux7() to IGNORED method group in TestMutuallyExclusivePlatformPredicates
>  - moved isOracleLinux7() method to Platform class
>  - simplified logic for determining OL 7
>  - Merge branch 'master' into pkcs11-ol79
>  - cleaned up MultipleLogins.java a little and added copyright date
>  - Merge branch 'master' into pkcs11-ol79
>  - Merge branch 'master' into pkcs11-ol79
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/b41df88f...eaaabc25

test/lib/jdk/test/lib/Platform.java line 354:

> 352:     public static boolean isOracleLinux7() {
> 353:         if (System.getProperty("os.name").toLowerCase().contains("linux") &&
> 354:                 System.getProperty("os.version").toLowerCase().contains("el")) {

Hi,  I checked and the el ("Enterprise Linux" ?)  is shown in os.version on RHEL and Oracle Linux.  But how reliable is it? Could this show up also on some other distros in os.version (maybe in the cpu-related string of uname output?) ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16547#discussion_r1448930089



More information about the security-dev mailing list