RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

Sean Mullan mullan at openjdk.org
Fri Jan 12 20:53:21 UTC 2024


On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang <jjiang at openjdk.org> wrote:

> ECDHKeyAgreement should validate the parameters before assigning them to the fields.

test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28:

> 26:  * @bug 8320449
> 27:  * @summary ECDHKeyAgreement should validate parameters before assigning them to fields.
> 28:  * @run junit ECDHKeyAgreementParamValidation

Most security regression tests don't use junit. I think it would be better to not rely on it. There is a similar asserts library for tests that you can use in `test/lib/jdk/test/lib/Asserts.java`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17373#discussion_r1450912957



More information about the security-dev mailing list