RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v2]

John Jiang jjiang at openjdk.org
Sat Jan 13 02:28:21 UTC 2024


On Sat, 13 Jan 2024 01:07:20 GMT, Bernd <duke at openjdk.org> wrote:

>> John Jiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more assertThrows on doPhase
>
> test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 90:
> 
>> 88:         KeyAgreement ka = KeyAgreement.getInstance("ECDH");
>> 89:         ka.init(kpP256.getPrivate());
>> 90:         try {
> 
> Should this be assertThrows like the other ones?

I assumed this point must fail and my fix for this bug didn't concern it.
Maybe some test on KeyAgreement already does that, so I didn't add a check point on it.

Anyway, just added this assertion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17373#discussion_r1451105467



More information about the security-dev mailing list