RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v2]

[Sean Mullan]

On Sat, 13 Jan 2024 00:49:39 GMT, John Jiang <jjiang at openjdk.org> wrote:

>> test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28:
>> 
>>> 26:  * @bug 8320449
>>> 27:  * @summary ECDHKeyAgreement should validate parameters before assigning them to fields.
>>> 28:  * @run junit ECDHKeyAgreementParamValidation
>> 
>> Most security regression tests don't use junit. I think it would be better to not rely on it. There is a similar asserts library for tests that you can use in `test/lib/jdk/test/lib/Asserts.java`.
>
> I originally didn't depend on JUnit. But this tool can easily execute multiple test cases independently.
> A single failed case doesn't make the whole test fail fast, and all cases always be executed.

Fair point, although there are ways to workaround that w/o junit.

AFAICT, this will be the first security test to depend on junit. @rhalade are you ok with this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17373#discussion_r1451787554